New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to set structured error early #58118
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
the
framework
flutter/packages/flutter repository. See also f: labels.
label
May 27, 2020
jacob314
reviewed
May 27, 2020
jacob314
reviewed
May 27, 2020
jacob314
reviewed
May 27, 2020
packages/flutter/test/widgets/widget_inspector_structured_error_test.dart
Outdated
Show resolved
Hide resolved
jacob314
reviewed
May 27, 2020
packages/flutter/test/widgets/widget_inspector_structured_error_test.dart
Outdated
Show resolved
Hide resolved
jacob314
reviewed
May 28, 2020
packages/flutter/test/widgets/widget_inspector_structured_error_test.dart
Outdated
Show resolved
Hide resolved
jacob314
reviewed
May 28, 2020
jacob314
reviewed
May 28, 2020
jacob314
reviewed
May 28, 2020
jacob314
reviewed
May 28, 2020
packages/flutter/test/widgets/widget_inspector_structured_error_test.dart
Outdated
Show resolved
Hide resolved
jacob314
reviewed
May 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jonahwilliams
approved these changes
May 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced May 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We noticed while testing exception logging in flutter-intellij that early exceptions (e.g. we tested throwing an exception immediately in the
build
method ofGalleryApp
) aren't handled by the structured handler. This change adds an option for a project to use the structured handler immediately instead of waiting for it to be registered later.Run output before change:
Run output after change:
Related Issues
(None - should I file one?)
Tests
I added the following tests:
setStructuredErrors
has been calledChecklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.
cc @jacob314