Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlooked break due to removal of Overflow #58327

Closed
wants to merge 1 commit into from
Closed

Fix overlooked break due to removal of Overflow #58327

wants to merge 1 commit into from

Conversation

mehmetf
Copy link
Contributor

@mehmetf mehmetf commented May 30, 2020

Description

Introduced in cd593dae#diff-7f71460835520a1820d69cd0b6994c01L45 removed Overflow enum but added it back to make it a non-breaking change. However, during that process, author forgot to add back the removed export.

Related Issues

Tests

None.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.

@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label May 30, 2020
@mehmetf mehmetf requested a review from liyuqian May 30, 2020 18:16
@mehmetf
Copy link
Contributor Author

mehmetf commented May 30, 2020

I need to submit this now since this is an important forward fix.

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehmetf
Copy link
Contributor Author

mehmetf commented May 30, 2020

Thanks Jonah. g3 results indicate that there are other problems with cd593da. The whole PR might be reverted. Waiting for Yuqian's input.

@mehmetf
Copy link
Contributor Author

mehmetf commented May 31, 2020

Superseded by #58344.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants