Fix remaining holes in stack trace demangling #60478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
a: tests
dnfield
reviewed
Jul 1, 2020
dnfield
reviewed
Jul 1, 2020
dnfield
reviewed
Jul 1, 2020
dnfield
reviewed
Jul 1, 2020
dnfield
reviewed
Jul 1, 2020
dnfield
reviewed
Jul 1, 2020
dnfield
reviewed
Jul 1, 2020
|
I actually renamed the file then boiled it down to what it is now, which is basically testing if FlutterErrorDetails.toDiagnosticsNode fails. Looking back at it, the added redundancy of a slightly more practical use case is probably a good thing so I'll just re-introduce the original test. |
|
Weird, your async_gap_test.dart doesn't fail if I comment out the assignment of demangleStackTrace, where was it supposed to fail before? |
|
I think as long as the test isn't failing it's fine, but we should keep the test. If something's broken, the test should end up failing on your new assert that we don't have a line like |
dnfield
added a commit
that referenced
this pull request
Jul 6, 2020
jonahwilliams
added a commit
that referenced
this pull request
Jul 6, 2020
dnfield
added a commit
that referenced
this pull request
Jul 7, 2020
dnfield
added a commit
that referenced
this pull request
Jul 7, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
* Implement stack trace demangling in the framework.
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
flutter#60916) This reverts commit d986fdc.
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…r#60478)" (flutter#60916)" (flutter#60996) This reverts commit 2c7e5dd.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up of #59900
Instead of forcing every implementer of
FlutterError.onError(both internally and externally) to manually demangle stack traces, we cover the small number of places in the framework that parse them.StackFrameparsing when it encounters package:stack_trace async gap delimiters, this prevents people from assuming the vm's own stack trace format changed, as we all initially assumed.FlutterError.demangleStackTraceto allow testing environments to provide their own demangle callbacks.FlutterError.defaultStackFilterorStackFrame.fromStackStringcould be passed an external stack trace.Related Issues
Fixes any remaining instances of #59893
Breaking Change
None of these changes should be breaking, and all local tests are passing.