Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FloatingActionButtonLocation for additional test case #61171

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Jul 9, 2020

Description

Adding on to this change: #60248
I realized while looking at #59272 and #59204 that I missed a case for the floating FloatingActionButtonLocations. The contentBottom of the Scaffold is affected by the BottomNavigationBar, and so needs to be taken into account for the float positions.

Related Issues

#59272
#59204
#60248

Tests

I added the following tests:

Added multiple configurations of BottomNavigationBar to the floating positional tests.
I also noticed upon revisiting that the positional arguments were a bit hard to follow, so I made them all named parameters in the related tests.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@Piinks Piinks added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: quality A truly polished experience labels Jul 9, 2020
@Piinks Piinks requested a review from HansMuller July 9, 2020 17:49
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Excellent implementation to test coverage ratio!

@fluttergithubbot fluttergithubbot merged commit e3079a3 into flutter:master Jul 9, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: quality A truly polished experience f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants