Fix FloatingActionButtonLocation for additional test case #61171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding on to this change: #60248
I realized while looking at #59272 and #59204 that I missed a case for the floating
FloatingActionButtonLocation
s. ThecontentBottom
of theScaffold
is affected by theBottomNavigationBar
, and so needs to be taken into account for the float positions.Related Issues
#59272
#59204
#60248
Tests
I added the following tests:
Added multiple configurations of BottomNavigationBar to the floating positional tests.
I also noticed upon revisiting that the positional arguments were a bit hard to follow, so I made them all named parameters in the related tests.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.