Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the flaky flag for frame policy test #61921

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Remove the flaky flag for frame policy test #61921

merged 1 commit into from
Jul 21, 2020

Conversation

CareF
Copy link
Contributor

@CareF CareF commented Jul 21, 2020

Description

This is a follow up of #61388 since the test is observed stable.

Related Issues

N/A

Tests

N/A

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@CareF CareF requested a review from liyuqian July 21, 2020 04:12
@CareF CareF self-assigned this Jul 21, 2020
@fluttergithubbot fluttergithubbot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Jul 21, 2020
liyuqian
liyuqian approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit e103ef6 into flutter:master Jul 21, 2020
@CareF CareF deleted the remove_frame_policy_test_flaky branch July 21, 2020 16:00
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
@CareF @Pragya007
remove frame policy test flaky (flutter#61921)
9b3a389
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@CareF @mingwandroid
remove frame policy test flaky (flutter#61921)
05b98d1
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liyuqian liyuqian liyuqian approved these changes

Assignees

@CareF CareF

Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CareF @liyuqian @googlebot @fluttergithubbot