Flutter doctor detect intellij on Linux #6227
Conversation
danrubel
changed the title
|
Neat. |
|
|
||
| @override | ||
| Future<ValidationResult> validate() async { | ||
| // TODO(danrubel) do not show Atom once IntelliJ support is complete |
There was a problem hiding this comment.
why? wouldn't we want to support as many IDEs as people write plugins for?
There was a problem hiding this comment.
Atom is deprecated... only critical fixes from the Dart team; it will bit rot until it reaches some point where it is badly broken. IntelliJ is now preferred and once IntelliJ support is on par with Atom, then Atom support will be discontinued. I'm not planning to remove Atom support from flutter doctor any time soon, but will eventually. If the Flutter team chooses to supply resources to support Atom, then this comment does not apply and should be removed.
There was a problem hiding this comment.
Ah, ok. Didn't realise we'd stopped supporting that plugin.
There was a problem hiding this comment.
Once the IntelliJ plugin is available (and at ~parity with the Atom plugin), we'll retire the flutter atom plugin, and the dart atom plugin will move to being community supported.
| final String version; | ||
| final String pluginsPath; | ||
|
|
||
| IntellijValidator(String title, {this.version, this.pluginsPath}) : super(title); |
There was a problem hiding this comment.
Ah! Analyzer did not complain so I missed it. Good eyes. Fixed.
| } | ||
| } | ||
| } else if (Platform.isMacOS) { | ||
| // TODO(danrubel) add support for Mac |
There was a problem hiding this comment.
nit: missing colon (// TODO(username): ...)
| if (_validateHasPackage(messages, 'Flutter', 'Flutter')) | ||
| installCount++; | ||
|
|
||
| if (installCount < 2) |
| return new ValidationResult( | ||
| installCount == 2 ? ValidationType.installed : ValidationType.partial, | ||
| messages, | ||
| statusInfo: 'version $version'); |
There was a problem hiding this comment.
unbalanced paren whitespace (add newline before trailing ))
|
|
This enhances
flutter doctoron Linux so that it can detect IntelliJ product installations and ensure that the needed plugins are installed.Future work:
For each IntelliJ product installation, you'll see something like this in
flutter doctoroutput:The "managing plugins" will only appear if one or more plugins are missing.
If Atom is installed, you'll also see something like this in the output:
If no supported IDEs are installed, you'll see:
Partially addresses #5875
@devoncarew