flutter doctor should test for IntelliJ not Atom

[mit-mit]

Current output:

$ flutter doctor
...
[✓] Atom - a lightweight development environment for Flutter
    • flutter plugin version 0.2.4
    • dartlang plugin version 0.6.38

[pq]

cc @danrubel

[mit-mit]

@danrubel thinking more about this, I actually think we should do the new IntelliJ checks for fishfood so that we catch config issues for new users there. Looks like pq already tagged it. Does that sound reasonable?

[danrubel]

flutter/flutter#5875

[mit-mit]

@danrubel should we consolidate those two bugs?

[pq]

@danrubel : is this reasonably on track for this week or should we push it to the next milestone?

[danrubel]

Detecting IntelliJ on Linux has landed. Working on detecting it on Mac today.

[pq]

🎉

[pq]

@danrubel : I think this was close for the Mac right?

Still only seeing Atom...

[danrubel]

It's close. Got distracted on other things. Need to address review comments for flutter/flutter#6262, land it, then we'll have support for Mac.

[pq]

Cool!

Question. After a sync, I'm not seeing anything. Does this mean it cannot find my IntelliJ installation(s)?

[~/src/git/clones/flutter] (master) $ flutter doctor
[✓] Flutter (on Mac OS, channel master)
    • Flutter at /Users/pquitslund/src/git/clones/flutter
    • Framework revision e20ee045ba (44 minutes ago), 2016-10-13 10:44:20
    • Engine revision cf774d580c
    • Tools Dart version 1.20.0-dev.10.2

[x] Android toolchain - develop for Android devices
    x Android Studio / Android SDK not found. Download from https://developer.android.com/sdk/
      (or visit https://flutter.io/setup/#android-setup for detailed instructions).

[-] iOS toolchain - develop for iOS devices (Xcode 7.3.1)
    • XCode at /Applications/Xcode.app/Contents/Developer
    • Xcode 7.3.1, Build version 7D1014
    x ideviceinstaller not available; this is used to discover connected iOS devices.
      Install via 'brew install ideviceinstaller'.
    x ios-deploy not available; this is used to deploy to connected iOS devices.
      Install via 'brew install ios-deploy'.

[✓] Atom - a lightweight development environment for Flutter
    • flutter plugin version 0.2.4
    • dartlang plugin version 0.6.37

[✓] Connected devices
    • iPhone 6s Plus • 0D7C1CC6-767A-469B-B98E-6D2A295E8CDD • ios (simulator)

[danrubel]

Where do you have it installed?
If you email me the exact path, I can check that I'm searching the right directories.

[pq]

/Application/Tools is where I have all my IDEs but I'm guessing that's not standard. Of course, what is standard?

[danrubel]

The standard (when you run the IntelliJ *.dmg) is for it to be installed in /Applications and that's where the code checks. Should it scan /Application subfolders as well?

[pq]

Makes sense!

Should it scan /Application subfolders as well?

I don't think it's unreasonable. At least one level deep. It's pretty common for folks to do a little management of their Apps directory.

[pq]

Landed. 🎉