Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[versions] update to the latest sdk versions #62687

Merged

Conversation

jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Jul 31, 2020

Description

Update to more null-safety versions

@flutter-dashboard flutter-dashboard bot added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Jul 31, 2020
@jonahwilliams jonahwilliams marked this pull request as ready for review July 31, 2020 18:57
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM what could go wrong?

@christopherfujino
Copy link
Member

LGTM what could go wrong?

other than all the tool_tests failing...

@christopherfujino
Copy link
Member

https://cirrus-ci.com/task/5116457497395200?command=main#L2139

ERR : Because test >=1.15.3 <1.16.0-nullsafety depends on test_api 0.2.18 and every version of flutter_driver from sdk depends on test_api 0.2.19-nullsafety, test >=1.15.3 <1.16.0-nullsafety is incompatible with flutter_driver from sdk.
    | So, because flutter_project depends on both flutter_driver any from sdk and test 1.15.3, version solving failed.
FINE: Exception type: SolveFailure
FINE: package:pub/src/solver/version_solver.dart 312:5   VersionSolver._resolveConflict
    | package:pub/src/solver/version_solver.dart 133:27  VersionSolver._propagate
    | package:pub/src/solver/version_solver.dart 97:11   VersionSolver.solve.<fn>
    | ===== asynchronous gap ===========================
    | dart:async                                         Future.catchError
    | package:pub/src/utils.dart 113:52                  captureErrors.wrappedCallback
    | package:stack_trace                                Chain.capture
    | package:pub/src/utils.dart 126:11                  captureErrors
    | package:pub/src/command_runner.dart 193:13         PubCommandRunner.runCommand

@christopherfujino
Copy link
Member

Possibly #61687

@fluttergithubbot fluttergithubbot merged commit c24772e into flutter:master Aug 3, 2020
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants