-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to the latest localizations - Adds missing DatePicker strings and fixes manually entering date for German #63026
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM without the _nb stuff for now.
Removed |
removing cp label in favor of #55535 |
* Fix SliverList scrollOffsetCorrection 0 case (#62615) * Case insensitive check flavor names against Xcode schemes (#61140) * Address misc time picker design issues (#62803) * Update to the latest localizations (#63026) * Removed the inputFormatters from the text input fields used by the Date Pickers (#63461) * Fix App.framework path in Podfile (#63412) * Update engine hash to 1.20.2 Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: Jenn Magder <magder@google.com> Co-authored-by: Rami <2364772+rami-a@users.noreply.github.com> Co-authored-by: Shi-Hao Hong <shihaohong@google.com> Co-authored-by: Darren Austin <darrenaustin@google.com>
Description
Continues on #62896, since @rami-a may have internet connectivity issues over the next day or so.
Updates the translated strings in the Flutter project.
Oddness with
_nb
files:Edit: It seems that the internal translation console now generates both
_nb.arb
and_no.arb
files. In that case, we should keep both versions to keep things consistent with the translation console. Given this change, we should be able to remove the workaround that makes_no.arb
and_nb.arb
synonyms in the framework code, but I'll do it in a separate PR to make sure that after removing the code, everything continues to work as expected.Somehow,
_nb.arb
files are now also added by Google's internal translation console alongside_no.arb
. I'll need to see if this is expected, as it may be a new update to how these are generated (we currently generate_nb.dart
source files through duplicating_no.arb
's messages, so it's quite odd that_nb.arb
files are being generated).Another oddity is that the_nb.arb
translations seem incomplete on the translation console. For this PR, I just manually removed the_nb.arb
source files, but this inconsistency needs to be investigated.Related Issues
Fixes #55535
Tests
I added the following tests:
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.