Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add padding around flutter api docs search input" #63113

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

goderbauer
Copy link
Member

@goderbauer goderbauer commented Aug 6, 2020

Reverts #44980

Causes some misalignment between entered text and the suggested text:

Screen Shot 2020-08-06 at 11 30 39 AM

/cc @xrr2016 @gspencergoog

Compare https://api.flutter.dev/ (doesn't have #44980 yet) with https://master-api.flutter.dev/ (includes #44980).

@flutter-dashboard flutter-dashboard bot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Aug 6, 2020
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer merged commit 6ab558d into master Aug 6, 2020
@goderbauer goderbauer deleted the revert-44980-chore/docs-search-input-update branch August 6, 2020 23:15
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants