[ReorderableListView] Fix item dropping animation #64140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Piinks
added
a: animation
Piinks
reviewed
Aug 27, 2020
There was a problem hiding this comment.
Hey @nero-angela welcome and thanks for the contribution! Can you write a test to verify that your change works? That will also make sure it is not un-done in the future.
nero-angela
force-pushed
the
reorderable_list_view
branch
from
310cfe1
to
1f245c2
Compare
nero-angela
force-pushed
the
reorderable_list_view
branch
from
1f245c2
to
8b29422
Compare
|
@Piinks I've applied your review. thank you 👏 |
…derable_list_view
Piinks
approved these changes
Sep 22, 2020
|
Hey @nero-angela I just noticed this was still open with a test failure. I have checked, and it was a flake. I'm setting it to pass and we should be able to get this merged! Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When dropping an item in the
ReorderableListView, a space flashes at the top of the dropping item.Below is a video of lifting and dropping an item in
ReorderableListView. In the left video, when dropping an item you can see the space betweenBandCat the moment.Related Issues
Tests
I added the following tests:
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.