[flutter_tools] migrate flutter_goldens, flutter_goldens client to null-safety #64201
Conversation
flutter-dashboard
bot
added
team
…safety_flutter_goldens
jonahwilliams
changed the title
| assert(process != null), | ||
| assert(platform != null), | ||
| httpClient = httpClient ?? io.HttpClient(); | ||
| required this.ci, |
There was a problem hiding this comment.
I decided to make this required since we don't handle null in the switch below.
| /*late*/ String cis; | ||
| String pullRequest; | ||
| String jobId; | ||
| String cis; |
There was a problem hiding this comment.
yay definite assignment analysis
| @@ -2,6 +2,7 @@ | |||
| // Use of this source code is governed by a BSD-style license that can be | |||
| // found in the LICENSE file. | |||
|
|
|||
| // @dart = 2.8 | |||
There was a problem hiding this comment.
This test uses too much mockito
| @@ -611,7 +607,11 @@ class FlutterLocalFileComparator extends FlutterGoldenFileComparator with LocalC | |||
| baseDirectory.createSync(recursive: true); | |||
| } | |||
|
|
|||
| goldens ??= SkiaGoldClient(baseDirectory); | |||
| goldens ??= SkiaGoldClient(baseDirectory, | |||
There was a problem hiding this comment.
The local comparator is used in a non-ci environment, so neither of these would be correct. 🤔
There was a problem hiding this comment.
WDUT about ContinuousIntegrationEnvironment.none ?
There was a problem hiding this comment.
SGTM. The switch statements will want it to be accounted for, it'll just be a pass through then. :) Thanks!
|
need to make some of these APIs nullable |
|
I needed to update the goldens library in flutter_test that this package depends on |
|
this is ready for another review |
Description
Unblock migration of flutter_test in #62886