Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update localizations #65993

Merged
merged 5 commits into from
Sep 23, 2020
Merged

Update localizations #65993

merged 5 commits into from
Sep 23, 2020

Conversation

shihaohong
Copy link
Contributor

@shihaohong shihaohong commented Sep 17, 2020

Description

Updated localizations based on latest translations from the Google team.

I also noticed that the translated text for searchFieldLabel appears to have "regressed", but was overridden to be in English a day after the localized versions were generated on the translation console. I'll need to make a request to see if this was intentional or not. I may opt to manually remove these changes in the meantime if that makes more sense. <-- These were not intended

Related Issues

Fixes #65018
Fixes part of #63372, the originally requested locales of af, fr, hy, nl, cs, sk and hu.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

@flutter-dashboard flutter-dashboard bot added a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. labels Sep 17, 2020
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@shihaohong shihaohong changed the title Update localizations [WIP] Update localizations Sep 17, 2020
@shihaohong
Copy link
Contributor Author

Edit: I'll wait until the translation team comes back with an answer regarding the "searchFieldLabel" text before moving forward with this update.

Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the pending update (or not) to the searchFieldLabel strings.

@shihaohong shihaohong changed the title [WIP] Update localizations Update localizations Sep 23, 2020
@fluttergithubbot fluttergithubbot merged commit 8ed0ac5 into flutter:master Sep 23, 2020
@shihaohong shihaohong deleted the translations branch December 3, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DateRangePicker has wrong input hint in french
4 participants