Fix bug when updating the divisions and value of the slider at the same time
#65998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
|
Looks good! Could you do the same update for |
@guidezpl Nice catch :) |
guidezpl
approved these changes
Sep 17, 2020
|
|
||
| testWidgets('Update the divisions and value at the same time for Slider', (WidgetTester tester) async { | ||
| // Regress test for https://github.com/flutter/flutter/issues/65943 | ||
| Widget buildFrame(double maxValue) { |
There was a problem hiding this comment.
Fixed.
Move the RangeSlider test case to another file.
| @@ -837,8 +837,11 @@ class _SliderRenderObjectWidget extends LeafRenderObjectWidget { | |||
| @override | |||
| void updateRenderObject(BuildContext context, _RenderSlider renderObject) { | |||
| renderObject | |||
| ..value = value | |||
| // We should update the `divisions` ahead of `value`, because the `value` | |||
There was a problem hiding this comment.
Since the regression tests link to this issue, this comment and the one in range_slider.dartarent' strictly necessary
|
Well done. Thanks.
|
guidezpl
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When updating the
divisionsandvalueof the slider at the same time, the position of the thumb is wrong because the olddivisionsvalue is used.Related Issues
Fixes #65943
Tests
See files.