Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows hostonly_devicelab tests. #66195

Merged
merged 7 commits into from Sep 22, 2020

Conversation

godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Sep 19, 2020

Description

Tests have been failing because windows 10 files use \r\n instead of just \n for file separators. Because of this the test was not replacing the assets/modules in pusbspec files.

Related Issues

Bug:
#64466

Tests

I added the following tests:

N/A

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard flutter-dashboard bot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Sep 19, 2020
Comment on lines -75 to -80
{
"name": "Linux gradle_plugin_light_apk_test",
"repo": "flutter",
"task_name": "linux_gradle_plugin_light_apk_test",
"flaky": false
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended to remove?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that one is still failing consistently.

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 35c8f19 into flutter:master Sep 22, 2020
@godofredoc godofredoc added this to To do in Migration to LUCI via automation Oct 16, 2020
@godofredoc godofredoc moved this from To do to Done in Migration to LUCI Jan 9, 2021
@godofredoc godofredoc deleted the fix_win_tests branch October 18, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants