-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix windows hostonly_devicelab tests. #66195
Conversation
88aaec0
to
d5c0ac1
Compare
{ | ||
"name": "Linux gradle_plugin_light_apk_test", | ||
"repo": "flutter", | ||
"task_name": "linux_gradle_plugin_light_apk_test", | ||
"flaky": false | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended to remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that one is still failing consistently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Tests have been failing because windows 10 files use \r\n instead of just \n for file separators. Because of this the test was not replacing the assets/modules in pusbspec files.
Related Issues
Bug:
#64466
Tests
I added the following tests:
N/A
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.