Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Stream logging from attached debugger on iOS" #66368

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Revert "Stream logging from attached debugger on iOS" #66368

merged 1 commit into from
Sep 22, 2020

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Sep 22, 2020

Reverts #66092

Re-revert, see #66364.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 22, 2020
@jmagman
Copy link
Member Author

jmagman commented Sep 22, 2020

Was reverted with #66359 and re-reverted. Try again.

@jmagman jmagman merged commit 8d2e257 into master Sep 22, 2020
@jmagman jmagman deleted the revert-66092-debug-attach branch September 22, 2020 18:30
@jmagman jmagman mentioned this pull request Sep 22, 2020
Closed
@dnfield
Copy link
Contributor

dnfield commented Sep 22, 2020

LGTM

@liyuqian
Copy link
Contributor

FYI: this commit (and #66092) affected the flutter_gallery_ios32__start_up benchmark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmagman @dnfield @liyuqian @googlebot