Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check git commands in Flutter version check test #66406

Merged
merged 1 commit into from Sep 23, 2020
Merged

Check git commands in Flutter version check test #66406

merged 1 commit into from Sep 23, 2020

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Sep 23, 2020

Description

Swap the Flutter version check test MockProcessManager for a FakeProcessManager and actually verify the git commands.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Sep 23, 2020
@jmagman jmagman self-assigned this Sep 23, 2020
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 23, 2020
@jmagman
Copy link
Member Author

jmagman commented Sep 23, 2020

Had this laying around in a branch, but I only finished one test. Better than nothing.

christopherfujino
christopherfujino approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino
Copy link
Member

Thanks for this. I wrote this test right before I discovered the FakeProcessManager and never got around to rewriting.

@jmagman jmagman merged commit f654346 into flutter:master Sep 23, 2020
@jmagman jmagman deleted the version-tests branch September 23, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees

@jmagman jmagman

Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmagman @christopherfujino @googlebot