Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check git commands in Flutter version check test #66406

Merged
merged 1 commit into from Sep 23, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/flutter_tools/lib/src/version.dart
Expand Up @@ -398,7 +398,7 @@ class FlutterVersion {
lenient: false
));
} on VersionCheckError {
// Don't perform the update check if the verison check failed.
// Don't perform the update check if the version check failed.
return;
}

Expand Down
50 changes: 49 additions & 1 deletion packages/flutter_tools/test/general.shard/version_test.dart
Expand Up @@ -28,8 +28,10 @@ final DateTime _stampOutOfDate = _testClock.ago(FlutterVersion.checkAgeConsidere
void main() {
MockProcessManager mockProcessManager;
MockCache mockCache;
FakeProcessManager processManager;

setUp(() {
processManager = FakeProcessManager.list(<FakeCommand>[]);
mockProcessManager = MockProcessManager();
mockCache = MockCache();
});
Expand Down Expand Up @@ -60,11 +62,57 @@ void main() {
expectSetStamp: true,
channel: channel,
);

processManager.addCommand(const FakeCommand(
command: <String>['git', '-c', 'log.showSignature=false', 'log', '-n', '1', '--pretty=format:%H'],
stdout: '1234abcd',
));

processManager.addCommand(const FakeCommand(
command: <String>['git', 'tag', '--points-at', 'HEAD'],
));

processManager.addCommand(const FakeCommand(
command: <String>['git', 'describe', '--match', '*.*.*', '--first-parent', '--long', '--tags'],
stdout: '0.1.2-3-1234abcd',
));

processManager.addCommand(FakeCommand(
command: const <String>['git', 'rev-parse', '--abbrev-ref', '--symbolic', '@{u}'],
stdout: channel,
));

processManager.addCommand(FakeCommand(
command: const <String>['git', '-c', 'log.showSignature=false', 'log', '-n', '1', '--pretty=format:%ad', '--date=iso'],
stdout: getChannelUpToDateVersion().toString(),
));

processManager.addCommand(const FakeCommand(
command: <String>['git', 'remote'],
));

processManager.addCommand(const FakeCommand(
command: <String>['git', 'remote', 'add', '__flutter_version_check__', 'https://github.com/flutter/flutter.git'],
));

processManager.addCommand(FakeCommand(
command: <String>['git', 'fetch', '__flutter_version_check__', channel],
));

processManager.addCommand(FakeCommand(
command: <String>['git', '-c', 'log.showSignature=false', 'log', '__flutter_version_check__/$channel', '-n', '1', '--pretty=format:%ad', '--date=iso'],
stdout: getChannelOutOfDateVersion().toString(),
));
processManager.addCommand(const FakeCommand(
command: <String>['git', 'remote'],
));

await globals.flutterVersion.checkFlutterVersionFreshness();
_expectVersionMessage('');
expect(processManager.hasRemainingExpectations, isFalse);
}, overrides: <Type, Generator>{
FlutterVersion: () => FlutterVersion(_testClock),
ProcessManager: () => mockProcessManager,
ProcessManager: () => processManager,
Cache: () => mockCache,
});

Expand Down