Remove deployment to play store for linux case in deploy_gallery test #67349
Conversation
flutter-dashboard
bot
added
the
team
| set -x | ||
| ( | ||
| cd dev/integration_tests/flutter_gallery/android | ||
| bundle exec fastlane deploy_play_store |
There was a problem hiding this comment.
you can remove all fastlane related code in the codebase as well. There are some in .cirrus.yaml. You can skip fastlane related setup in the dockerfile as well. Also the various fastlane related files in flutter_gallery/android|ios/fastlane.
There was a problem hiding this comment.
Please help take another look.
Gemfile.lock was updated after I ran bundle after removing fastlane codes from Gemfile.
| @@ -2,7 +2,3 @@ | |||
| # in dev/ci/docker_linux/Dockerfile to retrigger a Docker build on Cirrus. | |||
|
|
|||
| source "https://rubygems.org" | |||
|
|
|||
There was a problem hiding this comment.
This PR looks good to me.
As a nit, can you also update the timestamp on the Dockerfile https://github.com/flutter/flutter/blob/master/dev/ci/docker_linux/Dockerfile#L13, to bust the cache and trigger a rebuild of the Dockerfile. I want to make sure that all the linux tests pass without fastlane installed.
|
LGTM. Thanks! |
Description
We are migrating
deploy_galleryto LUCI, but find the deployment to play store has not been run for a while, and can be removed.This is to remove deployment to play store for
deploy_gallerytest.Related Issues
#66707