Migrate some material tests to nnbd #67477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
goderbauer
force-pushed
the
migrateTestss
branch
from
c7833c1
to
8fdb910
Compare
gspencergoog
approved these changes
Oct 7, 2020
| @@ -96,8 +96,7 @@ abstract class PopupMenuEntry<T> extends StatefulWidget { | |||
| /// * [showMenu], a method to dynamically show a popup menu at a given location. | |||
| /// * [PopupMenuButton], an [IconButton] that automatically shows a menu when | |||
| /// it is tapped. | |||
| // ignore: prefer_void_to_null, https://github.com/dart-lang/sdk/issues/34416 | |||
| class PopupMenuDivider extends PopupMenuEntry<Null> { | |||
| class PopupMenuDivider extends PopupMenuEntry<Never> { | |||
There was a problem hiding this comment.
Aww, I'm jealous: I haven't found a reason to use Never yet!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dart-lang/sdk#40146
#62886