Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate old SnackBar methods #67947

Merged
merged 4 commits into from
Oct 19, 2020
Merged

Deprecate old SnackBar methods #67947

merged 4 commits into from
Oct 19, 2020

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Oct 12, 2020 •
edited
Loading

Description

This PR deprecates the old SnackBar methods in ScaffoldState. ScaffoldMessenger should be used instead.

Status: WIP, Identifying customers in need of migration.

Related Issues

#62921

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@Piinks Piinks added c: new feature Nothing broken; request for a new capability framework flutter/packages/flutter repository. See also f: labels. c: API break Backwards-incompatible API changes labels Oct 12, 2020
@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. work in progress; do not review labels Oct 12, 2020
@google-cla google-cla bot added the cla: yes label Oct 12, 2020
This was referenced Oct 12, 2020
Merged
Merged
Merged
Piinks
Piinks commented Oct 13, 2020
View reviewed changes
packages/flutter/lib/src/material/scaffold.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/material/scaffold.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/material/scaffold.dart Outdated Show resolved Hide resolved
@Piinks Piinks marked this pull request as ready for review October 13, 2020 14:41
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Piinks Piinks mentioned this pull request Oct 13, 2020
Merged
@Piinks Piinks changed the title [WIP] Deprecate old SnackBar methods Deprecate old SnackBar methods Oct 14, 2020
@fluttergithubbot fluttergithubbot merged commit 8df0c5e into flutter:master Oct 19, 2020
@Piinks Piinks mentioned this pull request Feb 16, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@HansMuller HansMuller Awaiting requested review from HansMuller

Assignees
No one assigned
Labels
c: API break Backwards-incompatible API changes c: new feature Nothing broken; request for a new capability f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Piinks @gspencergoog @fluttergithubbot