Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for "Pass RouteSettings to the internal Route in showCupertinoModalPopup" #67990

Merged
merged 10 commits into from
Oct 13, 2020
Merged

Fix for "Pass RouteSettings to the internal Route in showCupertinoModalPopup" #67990

merged 10 commits into from
Oct 13, 2020

Conversation

miquelbeltran
Copy link
Member

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Oct 13, 2020
@google-cla google-cla bot added the cla: yes label Oct 13, 2020
@miquelbeltran
Copy link
Member Author

miquelbeltran commented Oct 13, 2020 •
edited
Loading

Hi @goderbauer. I did as you requested here #67969 (comment)

goderbauer
goderbauer approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@goderbauer goderbauer merged commit 1aaa455 into flutter:master Oct 13, 2020
@miquelbeltran miquelbeltran deleted the mb-cupertinomodal-settings branch October 13, 2020 19:11
@miquelbeltran
Copy link
Member Author

Thank you @goderbauer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miquelbeltran @fluttergithubbot @goderbauer