Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devicelab] split end to end tests into driver targets #68410

Merged
merged 1 commit into from Oct 19, 2020

Conversation

jonahwilliams
Copy link
Member

Description

Split the integration_ui target into individual driver tests. Remove disabled screenshot tests

@flutter-dashboard flutter-dashboard bot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Oct 17, 2020
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Oct 17, 2020
@@ -899,16 +935,6 @@ tasks:
# required_agent_capabilities: ["linux/android"]
# flaky: true

# TODO(cyanglaz): Enable this test when we know how to test gold in device labs
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed commented out code

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyanglaz Do you want to create an issue to cover recreating this test in LUCI?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Done

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

description: >
Runs end-to-end Flutter tests on Android.
stage: devicelab
required_agent_capabilities: ["mac/android"]

integration_ui_keyboard_resize:
description: >
Runs end-to-end Flutter tests on Android.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These duplicated descriptions are kind of lame since they are testing different things, but the name of the test probably covers it.

@@ -899,16 +935,6 @@ tasks:
# required_agent_capabilities: ["linux/android"]
# flaky: true

# TODO(cyanglaz): Enable this test when we know how to test gold in device labs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyanglaz Do you want to create an issue to cover recreating this test in LUCI?

@jonahwilliams jonahwilliams merged commit 223df0c into flutter:master Oct 19, 2020
@jonahwilliams jonahwilliams deleted the fix_end_to_end_tests branch October 19, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants