New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[devicelab] split end to end tests into driver targets #68410
[devicelab] split end to end tests into driver targets #68410
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
@@ -899,16 +935,6 @@ tasks: | |||
# required_agent_capabilities: ["linux/android"] | |||
# flaky: true | |||
|
|||
# TODO(cyanglaz): Enable this test when we know how to test gold in device labs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed commented out code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cyanglaz Do you want to create an issue to cover recreating this test in LUCI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
description: > | ||
Runs end-to-end Flutter tests on Android. | ||
stage: devicelab | ||
required_agent_capabilities: ["mac/android"] | ||
|
||
integration_ui_keyboard_resize: | ||
description: > | ||
Runs end-to-end Flutter tests on Android. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These duplicated descriptions are kind of lame since they are testing different things, but the name of the test probably covers it.
@@ -899,16 +935,6 @@ tasks: | |||
# required_agent_capabilities: ["linux/android"] | |||
# flaky: true | |||
|
|||
# TODO(cyanglaz): Enable this test when we know how to test gold in device labs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cyanglaz Do you want to create an issue to cover recreating this test in LUCI?
Description
Split the integration_ui target into individual driver tests. Remove disabled screenshot tests