Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "update packages" #68622

Merged
merged 1 commit into from Oct 20, 2020
Merged

Revert "update packages" #68622

merged 1 commit into from Oct 20, 2020

Conversation

jonahwilliams
Copy link
Member

Reverts #68569

Broke several tests with compilation errors due to url_launcher. TBR @dnfield

@google-cla google-cla bot added the cla: yes label Oct 20, 2020
@jonahwilliams jonahwilliams merged commit 86c6b7f into master Oct 20, 2020
@jonahwilliams jonahwilliams deleted the revert-68569-master branch October 20, 2020 16:09
@dnfield
Copy link
Contributor

dnfield commented Oct 20, 2020

LGTM or whatever

@jonahwilliams
Copy link
Member Author

jonahwilliams commented Oct 20, 2020

2020-10-20T08:39:04.595944: stderr: [ +960 ms] /Users/flutter/.pub-cache/hosted/pub.dartlang.org/url_launcher_web-0.1.4+1/lib/url_launcher_web.dart:22:7: Error: The non-abstract class 'UrlLauncherPlugin' is missing implementations for these members:
                            stderr: [   +3 ms]  - UrlLauncherPlatform.linkDelegate
2020-10-20T08:39:04.597064: stderr: [        ] Try to either
                            stderr: [        ]  - provide an implementation,
                            stderr: [        ]  - inherit an implementation from a superclass or mixin,
                            stderr: [        ]  - mark the class as abstract, or
                            stderr: [        ]  - provide a 'noSuchMethod' implementation.
2020-10-20T08:39:04.598055: stderr: [        ] class UrlLauncherPlugin extends UrlLauncherPlatform {
                            stderr: [        ]       ^^^^^^^^^^^^^^^^^
                            stderr: [        ] /Users/flutter/.pub-cache/hosted/pub.dartlang.org/url_launcher_platform_interface-1.0.9/lib/url_launcher_platform_interface.dart:43:20: Context: 'UrlLauncherPlatform.linkDelegate' is defined here.
2020-10-20T08:39:04.598385: stderr: [        ]   LinkDelegate get linkDelegate;
                            stderr: [        ]                    ^^^^^^^^^^^^
2020-10-20T08:39:29.296377: stdout: [+24696 ms] Syncing files to device Web Server... (completed in 27.4s)
2020-10-20T08:39:29.297128: stdout: [   +1 ms] Synced 0.0MB.
2020-10-20T08:39:29.297719: stderr: [        ] Failed to compile application.
2020-10-20T08:39:29.302169: stdout: [   +4 ms] "flutter run" took 30,049ms.
2020-10-20T08:39:29.307892: stderr: [   +5 ms] 
                            stderr:            #0      throwToolExit (package:flutter_tools/src/base/common.dart:14:3)

Sorry, logs took a while

@dnfield
Copy link
Contributor

dnfield commented Oct 20, 2020

Thanks. @ditman any ideas on this one?

@ditman
Copy link
Member

ditman commented Oct 20, 2020

/cc @mdebbar added a linkDelegate recently; he might not have had time to publish all the packages he's worked on.

@ditman
Copy link
Member

ditman commented Oct 21, 2020

Closing the loop here: Mouad published the fix for this one. Apologies for the breakage! /cc @dnfield @jonahwilliams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants