Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert for RenderFlex intrinsics if using baseline alignment #70139

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

goderbauer
Copy link
Member

@goderbauer goderbauer commented Nov 9, 2020

Description

When CrossAxisAlignment.baseline is used in a RenderFlex we can't actually calculate any intrinsics sizes because baseline metrics are only available after layout (and the intrinsics are explicitly not doing a full layout). As documented for computeMinIntrinsicWidth under "When the intrinsic dimensions cannot be known", in these cases we should throw. Unfortunately, upto now that's not what we do. This PR implements the documented contract.

We do something similar for RenderParagraph in its _canComputeIntrinsics method.

Related Issues

#65895

Tests

I added the following tests:

  • added a test for RenderFlex

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Nov 9, 2020
@google-cla google-cla bot added the cla: yes label Nov 9, 2020
@goderbauer
Copy link
Member Author

/cc @tvolkert @Hixie

Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants