Assert for RenderFlex intrinsics if using baseline alignment #70139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
CrossAxisAlignment.baseline
is used in aRenderFlex
we can't actually calculate any intrinsics sizes because baseline metrics are only available after layout (and the intrinsics are explicitly not doing a full layout). As documented for computeMinIntrinsicWidth under "When the intrinsic dimensions cannot be known", in these cases we should throw. Unfortunately, upto now that's not what we do. This PR implements the documented contract.We do something similar for RenderParagraph in its _canComputeIntrinsics method.
Related Issues
#65895
Tests
I added the following tests:
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.