[flutter_tools] dont use autodetect enum for web #70189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
tool
pcsosinski
pushed a commit
to pcsosinski/flutter
that referenced
this pull request
Nov 13, 2020
pcsosinski
pushed a commit
that referenced
this pull request
Nov 14, 2020
) * Update engine hash to 1.24.0-10.1.pre * [null-safety] implement null-safe autodetection for the web (#70126) Fixes #69416 Fixes #70121 * [flutter_tools] dont use autodetect enum for web (#70189) * Update engine hash for build fix and pub DEP bump Co-authored-by: Jonah Williams <jonahwilliams@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuation of #70121
For web builds, the tool needs to determine whether sound null safety is enabled if autodetect is used. This update changes the determination to switch the autodetect mode on the device to the resolved version (sound/unsound) so the correct arguments are used.
The correct long term fix is to determine the null safety mode when computing the build info, but that involves a little more refactoring than I have time for now.