Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SdkType -> EnvironmentType #71095

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Nov 23, 2020

Description

Rename SdkType to EnvironmentType to make it more generic than just the SDK used to build.

The macOS code path was unused.

Related Issues

Will be used as part of #60109 to specify simulator and non-simulator engine framework paths.

@jmagman jmagman added the platform-ios iOS applications specifically label Nov 23, 2020
@jmagman jmagman self-assigned this Nov 23, 2020
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 23, 2020
@google-cla google-cla bot added the cla: yes label Nov 23, 2020
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member Author

jmagman commented Nov 23, 2020

Google test is failing because downstream hasn't picked up #70898, which removed AotBuilder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants