Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_tools]fix typo in printHowToConsumeAar,which case sync fail #71196

Merged
merged 1 commit into from Jan 7, 2021
Merged

[flutter_tools]fix typo in printHowToConsumeAar,which case sync fail #71196

merged 1 commit into from Jan 7, 2021

Conversation

vimerzhao
Copy link
Contributor

Description

according to: Groovy Language Documentation:

Any Groovy expression can be interpolated in all string literals, apart from single and triple-single-quoted strings.

I change typo ' to ", and modify related tests.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 25, 2020
@google-cla
Copy link

google-cla bot commented Nov 25, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@blasten
Copy link

blasten commented Dec 3, 2020

This is fine. Did you intend to fix a typo or change " for '?

@vimerzhao
Copy link
Contributor Author

This is fine. Did you intend to fix a typo or change " for '?

yes! ' will not work actually.

AUTHORS Outdated Show resolved Hide resolved
@zanderso
Copy link
Member

[PR Triage] I suspect Linux customer_testing is failing because the PR needs to be rebased. @vimerzhao could you please try rebasing this PR on to of master to retrigger the presubmit checks? Thanks!

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants