-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated CupertinoTextThemeData.brightness #72017
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This removes the deprecated
CupertinoTextThemeData.brightness
parameter that has reached the EOL . This property does not do anything. Compilation errors can be fixed by removing usages.Part of deprecations that are slated for removal for next release in https://flutter.dev/go/deprecation-lifetime
More context: https://medium.com/flutter/deprecation-lifetime-in-flutter-e4d76ee738ad
Related Issues
Deprecated in #41859
Tests
Tests for quick fix tool.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.