Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[text_input] prepare for custom text input sources" #74349

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Revert "[text_input] prepare for custom text input sources" #74349

merged 1 commit into from
Jan 20, 2021

Conversation

LongCatIsLooong
Copy link
Contributor

Reverts #72803

The PR seems to cause some internal tests to fail. A repro of the failure can be found in #74347.
Temporarily reverting the PR.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 20, 2021
@google-cla google-cla bot added the cla: yes label Jan 20, 2021
@LongCatIsLooong
Copy link
Contributor Author

/cc @jpnurmi

justinmc
justinmc approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fluttergithubbot fluttergithubbot merged commit 61299b1 into master Jan 20, 2021
@fluttergithubbot fluttergithubbot deleted the revert-72803-text-input-channel-connection branch January 20, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmc justinmc justinmc approved these changes

Assignees
No one assigned
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LongCatIsLooong @justinmc @fluttergithubbot