Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update all packages #76254

Merged
merged 2 commits into from Feb 18, 2021
Merged

Conversation

jonahwilliams
Copy link
Member

flutter update-packages --force-upgrade

@flutter-dashboard flutter-dashboard bot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Feb 18, 2021
@google-cla google-cla bot added the cla: yes label Feb 18, 2021
@@ -430,7 +430,7 @@ void main() {
expect(licenseResult.dependencies, isEmpty);
expect(licenseResult.errorMessages.single,
'package foo specified an additional license at /foo.txt, but this file could not be read:'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed memory file system to throw A FileSystemError instead of a FormatException to match the behavior of the real file system.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -430,7 +430,7 @@ void main() {
expect(licenseResult.dependencies, isEmpty);
expect(licenseResult.errorMessages.single,
'package foo specified an additional license at /foo.txt, but this file could not be read:'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonahwilliams jonahwilliams merged commit db1e9f0 into flutter:master Feb 18, 2021
@jonahwilliams jonahwilliams deleted the roll_more_deps branch February 18, 2021 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants