Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tabbar code sample #76387

Merged
merged 4 commits into from
Mar 31, 2021
Merged

Refactor tabbar code sample #76387

merged 4 commits into from
Mar 31, 2021

Conversation

Abhishek01039
Copy link
Contributor

@Abhishek01039 Abhishek01039 commented Feb 19, 2021 •
edited
Loading

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 19, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Feb 19, 2021
@Abhishek01039
Copy link
Contributor Author

Hello @HansMuller
can you please review this PR?
Thanks

@HansMuller HansMuller self-requested a review February 25, 2021 18:43
@Abhishek01039
Copy link
Contributor Author

hello @HansMuller
can you please review this PR?
Thanks

@Abhishek01039 Abhishek01039 mentioned this pull request Mar 11, 2021
Merged
8 tasks
@Abhishek01039
Copy link
Contributor Author

hello @HansMuller
Now I have resolved the conflicts.
can you please review this now?
Thanks

@Piinks Piinks added d: api docs Issues with https://api.flutter.dev/ documentation labels Mar 17, 2021
@Abhishek01039
Copy link
Contributor Author

Hello @Piinks
can you please review this PR again?
Thanks

@Abhishek01039
Copy link
Contributor Author

Hello @Piinks
is it possible to get some time for this PR?
Thanks

@Abhishek01039
Copy link
Contributor Author

Hello @Piinks
Please review this PR?
Thanks

Piinks
Piinks approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit f86c859 into flutter:master Mar 31, 2021
@Abhishek01039 Abhishek01039 deleted the tabbar_docs branch April 1, 2021 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

@HansMuller HansMuller Awaiting requested review from HansMuller

Assignees
No one assigned
Labels
d: api docs Issues with https://api.flutter.dev/ f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Abhishek01039 @Piinks @fluttergithubbot