[web] Allow the usage of url strategies without conditional imports #77103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdebbar
added
f: routes
johnpryan
approved these changes
Mar 2, 2021
ditman
reviewed
Mar 2, 2021
| /// | ||
| /// By default, the [HashUrlStrategy] subclass is used if the app doesn't | ||
| /// specify one. | ||
| abstract class UrlStrategy { |
There was a problem hiding this comment.
I'd recommend to export the common classes from another file, and only duplicate the things that really need a different implementation.
|
(PR triage): Are there still plans for this PR? |
|
@goderbauer yes, I'm planning to come back to this PR, address the review and land it. |
|
(PR triage): Are there still plans for this PR? |
mdebbar
force-pushed
the
cross_url_strategy
branch
from
483f916
to
409ce6a
Compare
|
|
ditman
reviewed
Nov 1, 2021
packages/flutter_web_plugins/lib/src/navigation/url_strategy.dart
Outdated
Show resolved
Hide resolved
ditman
reviewed
Nov 1, 2021
ditman
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, users have to do conditional imports in their apps in order to customize URL strategy. @johnpryan suggested that we make it possible to use the package without having to do conditional imports. This PR is an attempt to achieve that.
Thanks @ditman for the help!
Fixes #81910