-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ShaderMask on web for CupertinoContextMenu #77864
ShaderMask on web for CupertinoContextMenu #77864
Conversation
// conditional and just check for ShaderMask. | ||
// https://github.com/flutter/flutter/issues/52967. | ||
expect(find.byType(ShaderMask), kIsWeb ? findsNothing : findsOneWidget); | ||
expect(find.byType(ShaderMask), findsOneWidget); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is getting skipped when isBrowser
is true. Is the skip
still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch, there are a bunch of skipped tests that reference #44152. They seem to pass now, so I will unskip all of them.
Gold has detected about 2 untriaged digest(s) on patchset 3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for unskipping tests too.
I'm told that web now supports ShaderMask, so we can remove this workaround that was put into CupertinoContextMenu to simplify it so it didn't need ShaderMask on web.
Also unskips ShaderMask tests on web.
Closes #52967