Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "unnecessary" imports in test/commands.shard. #78665

Merged
merged 12 commits into from Apr 6, 2021
Merged

Remove "unnecessary" imports in test/commands.shard. #78665

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
64a166a
Remove "unnecessary" imports.
srawlins Mar 19, 2021
ac9fdcf
Fix test
srawlins Mar 20, 2021
547e50c
fix
srawlins Mar 22, 2021
1311f55
fix
srawlins Mar 25, 2021
131b48e
hide Directory
srawlins Mar 26, 2021
b26e722
Add back file_system
srawlins Mar 27, 2021
8811e5e
Merge branch 'master' into unn-commands.shard
srawlins Mar 29, 2021
9dc5253
Merge branch 'master' into unn-commands.shard
srawlins Apr 2, 2021
7d58158
Revert
srawlins Apr 2, 2021
b90ae9a
Revert one more
srawlins Apr 2, 2021
c03e67e
Merge branch 'master' into unn-commands.shard
srawlins Apr 2, 2021
038ff91
Merge branch 'master' into unn-commands.shard
srawlins Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/flutter_tools/test/commands.shard/hermetic/attach_test.dart
View file
Open in desktop
Expand Up @@ -11,7 +11,6 @@ import 'package:file/memory.dart';
import 'package:flutter_tools/src/base/common.dart';
import 'package:flutter_tools/src/base/dds.dart';
import 'package:flutter_tools/src/base/file_system.dart';
import 'package:flutter_tools/src/base/io.dart';
import 'package:flutter_tools/src/base/logger.dart';
import 'package:flutter_tools/src/base/terminal.dart';
import 'package:flutter_tools/src/cache.dart';
Expand All @@ -26,7 +25,6 @@ import 'package:flutter_tools/src/run_hot.dart';
import 'package:flutter_tools/src/vmservice.dart';
import 'package:meta/meta.dart';
import 'package:mockito/mockito.dart';
import 'package:process/process.dart';
import 'package:vm_service/vm_service.dart' as vm_service;

import '../../src/common.dart';
Expand Down
2 changes: 0 additions & 2 deletions packages/flutter_tools/test/commands.shard/hermetic/build_fuchsia_test.dart
View file
Open in desktop
Expand Up @@ -17,13 +17,11 @@ import 'package:flutter_tools/src/fuchsia/fuchsia_pm.dart';
import 'package:flutter_tools/src/fuchsia/fuchsia_sdk.dart';
import 'package:flutter_tools/src/project.dart';
import 'package:meta/meta.dart';
import 'package:process/process.dart';
import 'package:test/fake.dart';

import '../../src/common.dart';
import '../../src/context.dart';
import '../../src/fakes.dart';
import '../../src/testbed.dart';

// Defined globally for fakes to use.
FileSystem fileSystem;
Expand Down
2 changes: 0 additions & 2 deletions packages/flutter_tools/test/commands.shard/hermetic/build_ipa_test.dart
View file
Open in desktop
Expand Up @@ -12,11 +12,9 @@ import 'package:flutter_tools/src/cache.dart';
import 'package:flutter_tools/src/commands/build.dart';
import 'package:flutter_tools/src/ios/xcodeproj.dart';
import 'package:flutter_tools/src/reporting/reporting.dart';
import 'package:process/process.dart';

import '../../src/common.dart';
import '../../src/context.dart';
import '../../src/testbed.dart';

class FakeXcodeProjectInterpreterWithBuildSettings extends FakeXcodeProjectInterpreter {
@override
Expand Down
2 changes: 0 additions & 2 deletions packages/flutter_tools/test/commands.shard/hermetic/build_linux_test.dart
View file
Open in desktop
Expand Up @@ -18,13 +18,11 @@ import 'package:flutter_tools/src/commands/build_linux.dart';
import 'package:flutter_tools/src/features.dart';
import 'package:flutter_tools/src/project.dart';
import 'package:flutter_tools/src/reporting/reporting.dart';
import 'package:process/process.dart';
import 'package:test/fake.dart';

import '../../src/common.dart';
import '../../src/context.dart';
import '../../src/fakes.dart';
import '../../src/testbed.dart';

const String _kTestFlutterRoot = '/flutter';

Expand Down
2 changes: 0 additions & 2 deletions packages/flutter_tools/test/commands.shard/hermetic/build_macos_test.dart
View file
Open in desktop
Expand Up @@ -20,12 +20,10 @@ import 'package:flutter_tools/src/features.dart';
import 'package:flutter_tools/src/ios/xcodeproj.dart';
import 'package:flutter_tools/src/project.dart';
import 'package:flutter_tools/src/reporting/reporting.dart';
import 'package:process/process.dart';

import '../../src/common.dart';
import '../../src/context.dart';
import '../../src/fakes.dart';
import '../../src/testbed.dart';

class FakeXcodeProjectInterpreterWithProfile extends FakeXcodeProjectInterpreter {
@override
Expand Down
1 change: 0 additions & 1 deletion packages/flutter_tools/test/commands.shard/hermetic/build_web_test.dart
View file
Open in desktop
Expand Up @@ -22,7 +22,6 @@ import 'package:flutter_tools/src/web/compile.dart';
import '../../src/common.dart';
import '../../src/context.dart';
import '../../src/fakes.dart';
import '../../src/testbed.dart';

void main() {
FileSystem fileSystem;
Expand Down
2 changes: 0 additions & 2 deletions packages/flutter_tools/test/commands.shard/hermetic/clean_test.dart
View file
Open in desktop
Expand Up @@ -5,7 +5,6 @@
// @dart = 2.8

import 'package:file/memory.dart';
import 'package:flutter_tools/src/base/context.dart';
import 'package:flutter_tools/src/base/file_system.dart';
import 'package:flutter_tools/src/base/logger.dart';
import 'package:flutter_tools/src/base/platform.dart';
Expand All @@ -14,7 +13,6 @@ import 'package:flutter_tools/src/ios/xcodeproj.dart';
import 'package:flutter_tools/src/macos/xcode.dart';
import 'package:flutter_tools/src/project.dart';
import 'package:mockito/mockito.dart';
import 'package:process/process.dart';

import '../../src/common.dart';
import '../../src/context.dart';
Expand Down
1 change: 0 additions & 1 deletion packages/flutter_tools/test/commands.shard/hermetic/config_test.dart
View file
Open in desktop
Expand Up @@ -9,7 +9,6 @@ import 'dart:convert';
import 'package:args/command_runner.dart';
import 'package:flutter_tools/src/android/android_sdk.dart';
import 'package:flutter_tools/src/android/android_studio.dart';
import 'package:flutter_tools/src/base/context.dart';
import 'package:flutter_tools/src/base/file_system.dart';
import 'package:flutter_tools/src/build_info.dart';
import 'package:flutter_tools/src/cache.dart';
Expand Down
1 change: 0 additions & 1 deletion packages/flutter_tools/test/commands.shard/hermetic/create_usage_test.dart
View file
Open in desktop
Expand Up @@ -14,7 +14,6 @@ import 'package:flutter_tools/src/reporting/reporting.dart';
import 'package:flutter_tools/src/globals.dart' as globals;

import '../../src/common.dart';
import '../../src/context.dart';
import '../../src/testbed.dart';

void main() {
Expand Down
1 change: 0 additions & 1 deletion packages/flutter_tools/test/commands.shard/hermetic/daemon_test.dart
View file
Open in desktop
Expand Up @@ -23,7 +23,6 @@ import '../../src/common.dart';
import '../../src/context.dart';
import '../../src/fakes.dart';
import '../../src/mocks.dart';
import '../../src/testbed.dart';

void main() {
Daemon daemon;
Expand Down
1 change: 0 additions & 1 deletion packages/flutter_tools/test/commands.shard/hermetic/devices_test.dart
View file
Open in desktop
Expand Up @@ -12,7 +12,6 @@ import 'package:flutter_tools/src/cache.dart';
import 'package:flutter_tools/src/commands/devices.dart';
import 'package:flutter_tools/src/device.dart';
import 'package:flutter_tools/src/globals.dart' as globals;
import 'package:process/process.dart';

import '../../src/common.dart';
import '../../src/context.dart';
Expand Down
2 changes: 0 additions & 2 deletions packages/flutter_tools/test/commands.shard/hermetic/doctor_test.dart
View file
Open in desktop
Expand Up @@ -29,13 +29,11 @@ import 'package:flutter_tools/src/vscode/vscode.dart';
import 'package:flutter_tools/src/vscode/vscode_validator.dart';
import 'package:flutter_tools/src/web/workflow.dart';
import 'package:mockito/mockito.dart';
import 'package:process/process.dart';
import 'package:fake_async/fake_async.dart';

import '../../src/common.dart';
import '../../src/context.dart';
import '../../src/fakes.dart';
import '../../src/testbed.dart';

FakePlatform _kNoColorOutputPlatform() => FakePlatform(
localeName: 'en_US.UTF-8',
Expand Down
1 change: 0 additions & 1 deletion packages/flutter_tools/test/commands.shard/hermetic/precache_test.dart
View file
Open in desktop
Expand Up @@ -8,7 +8,6 @@ import 'package:flutter_tools/src/base/logger.dart';
import 'package:flutter_tools/src/base/platform.dart';
import 'package:flutter_tools/src/cache.dart';
import 'package:flutter_tools/src/commands/precache.dart';
import 'package:flutter_tools/src/runner/flutter_command.dart';
import 'package:mockito/mockito.dart';

import '../../src/common.dart';
Expand Down
2 changes: 0 additions & 2 deletions packages/flutter_tools/test/commands.shard/hermetic/run_test.dart
View file
Open in desktop
Expand Up @@ -11,7 +11,6 @@ import 'package:file/memory.dart';
import 'package:flutter_tools/src/application_package.dart';
import 'package:flutter_tools/src/artifacts.dart';
import 'package:flutter_tools/src/base/common.dart';
import 'package:flutter_tools/src/base/context.dart';
import 'package:flutter_tools/src/base/file_system.dart';
import 'package:flutter_tools/src/base/io.dart';
import 'package:flutter_tools/src/base/logger.dart';
Expand All @@ -33,7 +32,6 @@ import 'package:vm_service/vm_service.dart';
import '../../src/common.dart';
import '../../src/context.dart';
import '../../src/fakes.dart';
import '../../src/testbed.dart';

void main() {
group('run', () {
Expand Down
2 changes: 0 additions & 2 deletions packages/flutter_tools/test/commands.shard/hermetic/shell_completion_test.dart
View file
Open in desktop
Expand Up @@ -6,12 +6,10 @@

import 'package:file/memory.dart';
import 'package:flutter_tools/src/base/common.dart';
import 'package:flutter_tools/src/base/context.dart';
import 'package:flutter_tools/src/base/file_system.dart';
import 'package:flutter_tools/src/base/io.dart';
import 'package:flutter_tools/src/cache.dart';
import 'package:flutter_tools/src/commands/shell_completion.dart';
import 'package:process/process.dart';
import 'package:flutter_tools/src/globals.dart' as globals;

import '../../src/common.dart';
Expand Down
2 changes: 0 additions & 2 deletions packages/flutter_tools/test/commands.shard/hermetic/test_test.dart
View file
Open in desktop
Expand Up @@ -20,11 +20,9 @@ import 'package:flutter_tools/src/test/runner.dart';
import 'package:flutter_tools/src/test/test_wrapper.dart';
import 'package:flutter_tools/src/test/watcher.dart';
import 'package:meta/meta.dart';
import 'package:process/process.dart';

import '../../src/common.dart';
import '../../src/context.dart';
import '../../src/testbed.dart';

const String _pubspecContents = '''
dev_dependencies:
Expand Down
1 change: 0 additions & 1 deletion packages/flutter_tools/test/commands.shard/permeable/build_aar_test.dart
View file
Open in desktop
Expand Up @@ -15,7 +15,6 @@ import 'package:flutter_tools/src/project.dart';
import 'package:flutter_tools/src/reporting/reporting.dart';
import 'package:flutter_tools/src/globals.dart' as globals;
import 'package:meta/meta.dart';
import 'package:process/process.dart';
import 'package:test/fake.dart';

import '../../src/android_common.dart';
Expand Down
3 changes: 1 addition & 2 deletions packages/flutter_tools/test/commands.shard/permeable/build_apk_test.dart
View file
Open in desktop
Expand Up @@ -4,12 +4,11 @@

// @dart = 2.8

import 'dart:io';
import 'dart:io' hide Directory;

import 'package:args/command_runner.dart';
import 'package:flutter_tools/src/android/android_builder.dart';
import 'package:flutter_tools/src/android/android_sdk.dart';
import 'package:flutter_tools/src/base/context.dart';
import 'package:flutter_tools/src/base/file_system.dart';

import 'package:flutter_tools/src/cache.dart';
Expand Down
2 changes: 0 additions & 2 deletions packages/flutter_tools/test/commands.shard/permeable/build_appbundle_test.dart
View file
Open in desktop
Expand Up @@ -7,14 +7,12 @@
import 'package:args/command_runner.dart';
import 'package:flutter_tools/src/android/android_builder.dart';
import 'package:flutter_tools/src/android/android_sdk.dart';
import 'package:flutter_tools/src/base/context.dart';
import 'package:flutter_tools/src/base/file_system.dart';
import 'package:flutter_tools/src/cache.dart';
import 'package:flutter_tools/src/commands/build_appbundle.dart';
import 'package:flutter_tools/src/globals.dart' as globals;
import 'package:flutter_tools/src/project.dart';
import 'package:flutter_tools/src/reporting/reporting.dart';
import 'package:process/process.dart';
import 'package:test/fake.dart';

import '../../src/android_common.dart';
Expand Down
2 changes: 0 additions & 2 deletions packages/flutter_tools/test/commands.shard/permeable/build_bundle_test.dart
View file
Open in desktop
Expand Up @@ -16,13 +16,11 @@ import 'package:flutter_tools/src/commands/build_bundle.dart';
import 'package:flutter_tools/src/features.dart';
import 'package:flutter_tools/src/reporting/reporting.dart';
import 'package:mockito/mockito.dart';
import 'package:process/process.dart';
import 'package:flutter_tools/src/globals.dart' as globals;

import '../../src/common.dart';
import '../../src/context.dart';
import '../../src/fakes.dart';
import '../../src/testbed.dart';

void main() {
Cache.disableLocking();
Expand Down
1 change: 0 additions & 1 deletion packages/flutter_tools/test/commands.shard/permeable/create_test.dart
View file
Open in desktop
Expand Up @@ -32,7 +32,6 @@ import '../../src/context.dart';
import '../../src/fake_http_client.dart';
import '../../src/fakes.dart';
import '../../src/pubspec_schema.dart';
import '../../src/testbed.dart';

const String _kNoPlatformsMessage = 'You\'ve created a plugin project that doesn\'t yet support any platforms.\n';
const String frameworkRevision = '12345678';
Expand Down
1 change: 0 additions & 1 deletion packages/flutter_tools/test/commands.shard/permeable/devices_test.dart
View file
Open in desktop
Expand Up @@ -21,7 +21,6 @@ import 'package:mockito/mockito.dart';
import '../../src/common.dart';
import '../../src/context.dart';
import '../../src/fakes.dart';
import '../../src/testbed.dart';

void main() {
setUpAll(() {
Expand Down
2 changes: 0 additions & 2 deletions packages/flutter_tools/test/commands.shard/permeable/packages_test.dart
View file
Open in desktop
Expand Up @@ -18,14 +18,12 @@ import 'package:flutter_tools/src/cache.dart';
import 'package:flutter_tools/src/commands/packages.dart';
import 'package:flutter_tools/src/dart/pub.dart';
import 'package:flutter_tools/src/reporting/reporting.dart';
import 'package:process/process.dart';
import 'package:flutter_tools/src/globals.dart' as globals;

import '../../src/common.dart';
import '../../src/context.dart';
import '../../src/fake_process_manager.dart';
import '../../src/fakes.dart';
import '../../src/testbed.dart';

void main() {
Cache.disableLocking();
Expand Down
1 change: 0 additions & 1 deletion packages/flutter_tools/test/commands.shard/permeable/upgrade_test.dart
View file
Open in desktop
Expand Up @@ -14,7 +14,6 @@ import 'package:flutter_tools/src/globals.dart' as globals;
import 'package:flutter_tools/src/persistent_tool_state.dart';
import 'package:flutter_tools/src/runner/flutter_command.dart';
import 'package:flutter_tools/src/version.dart';
import 'package:process/process.dart';

import '../../src/common.dart';
import '../../src/context.dart';
Expand Down