Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change all dynamic slot to Object type #78928

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Conversation

xu-baolin
Copy link
Member

This patch change all the dynamic slot to Object? or Object type.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 24, 2021
@google-cla google-cla bot added the cla: yes label Mar 24, 2021
Copy link
Contributor

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All this really does is enable type-checking for the existing dynamic slots right? Have we run into issues here?

@xu-baolin
Copy link
Member Author

In fact, no specific issues have been encountered. We should try to avoid using the dynamic type. Sometimes it hides danger, doesn't it?

@shihaohong
Copy link
Contributor

Yeah, I was just curious why you decided to work on this :) I thought maybe you ran into some failure case

@shihaohong shihaohong merged commit 2edb685 into flutter:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants