[flutter_tools] use Url path.Context for joining URI #79566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
flutter-dashboard
bot
added
the
tool
jonahwilliams
commented
Apr 1, 2021
| }; | ||
|
|
||
| // Construct a URL that does not end in a `/`. | ||
| await expectLater(() => connectToVmService(Uri.parse('http://localhost:8181/foo')), throwsException); |
There was a problem hiding this comment.
Without this change a \ is appended and then URL encoded into %5c
zanderso
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just happens to work on windows, since
/is treated as a path joiner as well and the URL always ends with a/so a\is never appended. Switch to path's URL context to be technically correct.