[flutter_tools] add timeline ANR integration test #79991
Conversation
flutter-dashboard
bot
added
the
tool
| 'for the bug this test is attempting to exercise.' | ||
| ); | ||
| }); | ||
| await vmService.streamListen(EventStreams.kVM); |
There was a problem hiding this comment.
I just went ahead and subscribed to everything
| // found in the LICENSE file. | ||
|
|
||
| // @dart = 2.8 | ||
|
|
| await vmService.streamListen(EventStreams.kHeapSnapshot); | ||
| await vmService.streamListen(EventStreams.kStdout); | ||
| await vmService.streamListen(EventStreams.kStderr); | ||
| await Future<void>.delayed(const Duration(seconds: 10)); |
There was a problem hiding this comment.
Can this be replaced with polling on the calls we expect to eventually succeed?
There was a problem hiding this comment.
Or before suggesting that, I should ask what goes wrong without this delay. What could go wrong if something takes longer than expected?
There was a problem hiding this comment.
Nothing goes wrong actually, I could probably take it out. I wanted to be sure that at least some timeline events were logged
There was a problem hiding this comment.
I wasn't able to find a consistent signal in the timeline. Instead, I updated this test to poll for 30 seconds to confirm that the app is still responding.
|
|
||
| // Verify that the app can be interacted with by querying the brightness. | ||
| // There may be a delay before the app stops responding, so poll for at least | ||
| // 30 seconds. |
There was a problem hiding this comment.
10 interactions separated by a 3 second delay isn't necessarily 30 seconds. It might be less flaky to say something like, "All interactions initiated in the first 30 seconds (and separated by 3 seconds) are completed within 5 minutes" rather than using a fixed number of 10 interactions.
There was a problem hiding this comment.
I'm not really sure what you're asking for here. I don't ever fail the test based on the time elapsed, I only leave a note in the logs that it may have failed.
|
Update the test to interact with the app for 30 seconds, instead of making 10 interactions 3 seconds apart |
To prevent #79498 from being able to roll into the framework, add a test which subscribes to all event streams, logs some timeline traces, and then checks if the app is responsive.
The nature of the bug means that this test will hang forever if it fails. To prevent this from being diagnosed as an infra issue, I added a 5 minute warning message which links to the bug in question.