Migrate more tool unit tests to null safety #80002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
added
team
jmagman
force-pushed
the
null-test-general
branch
from
ee012fb
to
6b7bc59
Compare
jmagman
commented
Apr 8, 2021
| @@ -118,7 +118,7 @@ class AppContext { | |||
| if (value == null && _parent != null) { | |||
| value = _parent!.get<T>(); | |||
| } | |||
| return _unboxNull(value ?? _generateIfNecessary(T, _fallbacks)) as T; | |||
| return _unboxNull(value ?? _generateIfNecessary(T, _fallbacks)) as T?; | |||
There was a problem hiding this comment.
Also in #79985, let's see which one merges first.
| @@ -48,7 +48,7 @@ bool _inUnitTest() { | |||
| /// | |||
| /// The specification for the language version tag is defined at: | |||
| /// https://github.com/dart-lang/language/blob/master/accepted/future-releases/language-versioning/feature-specification.md#individual-library-language-version-override | |||
| LanguageVersion determineLanguageVersion(File file, Package package, String flutterRoot) { | |||
| LanguageVersion determineLanguageVersion(File file, Package? package, String flutterRoot) { | |||
There was a problem hiding this comment.
This is the only actual non-test change.
| @@ -9,7 +9,7 @@ import 'package:flutter_tools/src/doctor_validator.dart'; | |||
| import 'package:flutter_tools/src/linux/linux_doctor.dart'; | |||
|
|
|||
| import '../../src/common.dart'; | |||
| import '../../src/context.dart'; | |||
| import '../../src/fake_process_manager.dart'; | |||
There was a problem hiding this comment.
Getting ready to migrate fake_process_manager.
jmagman
force-pushed
the
null-test-general
branch
from
6b7bc59
to
e1d3944
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #71511