Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_releases] Flutter Dev 2.2.0-10.1.pre Framework Cherrypicks #80459

Conversation

christopherfujino
Copy link
Member

@christopherfujino christopherfujino commented Apr 14, 2021

Scheduled Cherrypicks

Known Pre-Submit Failures

@flutter-dashboard flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 14, 2021
@google-cla google-cla bot added the cla: yes label Apr 14, 2021
@christopherfujino christopherfujino changed the base branch from master to flutter-2.2-candidate.10 April 14, 2021 20:03
@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard flutter-dashboard bot added the engine flutter/engine repository. See also e: labels. label Apr 14, 2021
@christopherfujino christopherfujino requested review from jmagman, jonahwilliams and kf6gpe and removed request for jmagman April 14, 2021 23:53
@christopherfujino christopherfujino marked this pull request as ready for review April 14, 2021 23:54
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member

jmagman commented Apr 15, 2021

module_test_ios is failing with an add to app host runtime codesigning crash:
codesign_crash.txt

Exception Type:        EXC_BAD_ACCESS (Code Signature Invalid)
Exception Codes:       0x0000000000000032, 0x0000000107614000
Exception Note:        EXC_CORPSE_NOTIFY

Termination Reason:    Namespace CODESIGNING, Code 0x2

The top of the log says This bot does not support codesigning
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8849863879990991456/+/steps/run_module_test_ios/0/stdout

@christopherfujino christopherfujino merged commit 0941968 into flutter:flutter-2.2-candidate.10 Apr 15, 2021
@christopherfujino christopherfujino deleted the cherrypicks-flutter-2.2-candidate.10 branch April 15, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants