Dispose thumbPainter in Switch to avoid crash #81089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
chunhtai
approved these changes
Apr 23, 2021
|
This pull request is not suitable for automatic merging in its current state.
|
HansMuller
approved these changes
Apr 23, 2021
|
|
||
| @override | ||
| void dispose() { | ||
| _cachedThumbPainter?.dispose(); |
There was a problem hiding this comment.
Should we null _cachedThubPainter and other internal fields so that holding a reference to a disposed _MaterialSwitch doesn't prevent the image from being GC'd?
There was a problem hiding this comment.
Good idea, will make that change.
goderbauer
force-pushed
the
switchCrasher
branch
2 times, most recently
from
8531cda
to
21cc219
Compare
goderbauer
force-pushed
the
switchCrasher
branch
from
21cc219
to
abe6c52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes b/186203085
The thumpPainter is invoking its onChanged callback (_handleDecorationChanged) when the given ImageProvider finally completes to trigger a repaint. If the Switch is already disposed at that moment, the
notifyListenerscall in_handleDecorationChangedcrashes. To avoid all that, the thumbPainter must be disposed when the Switch is disposed or when it is replaced with another painter.