Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flutter_tools] remove mocks from xcode test #81451

Merged
merged 1 commit into from Apr 30, 2021
Merged

[flutter_tools] remove mocks from xcode test #81451

merged 1 commit into from Apr 30, 2021

Conversation

jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Apr 29, 2021 •
edited

Work towards #71511 . Remove mocks from xcode test

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 29, 2021
@google-cla google-cla bot added the cla: yes label Apr 29, 2021
@jonahwilliams jonahwilliams requested review from jmagman and zanderso and removed request for jmagman April 29, 2021 14:57
christopherfujino
christopherfujino approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams merged commit ce9aee6 into flutter:master Apr 30, 2021
@jonahwilliams jonahwilliams deleted the remove_more_mock_13122ad branch April 30, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@zanderso zanderso Awaiting requested review from zanderso

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonahwilliams @christopherfujino