Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "MouseRegion enter/exit event can be triggered with button pressed" #81557

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

dkwingsmt
Copy link
Contributor

Reverts #8114.

This PR has caused an internal breakage (internal issue b/186846732).

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 30, 2021
@google-cla google-cla bot added the cla: yes label Apr 30, 2021
@dkwingsmt
Copy link
Contributor Author

cc @xu-baolin

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkwingsmt dkwingsmt merged commit d97f41c into master Apr 30, 2021
@dkwingsmt dkwingsmt deleted the revert-81148-0425mouse branch April 30, 2021 19:35
@dkwingsmt
Copy link
Contributor Author

Merging revert without flutter-build.

@xu-baolin
Copy link
Member

@dkwingsmt hi, any details about the internal test?

@dkwingsmt
Copy link
Contributor Author

@xu-baolin Not yet, I'm fully occupied on some other issues. Will get back on this asap.

dkwingsmt added a commit to dkwingsmt/flutter that referenced this pull request May 24, 2021
dkwingsmt added a commit that referenced this pull request Jun 12, 2021
…ssed (#83253)

* Revert "Revert "MouseRegion enter/exit event can be triggered with button pressed (#81148)" (#81557)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants