Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_tools] add --verbose flag to pub global activate #82719

Merged

Conversation

christopherfujino
Copy link
Member

try to debug #82142

@flutter-dashboard flutter-dashboard bot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label May 17, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label May 17, 2021
@Hixie
Copy link
Contributor

Hixie commented May 17, 2021

test-exempt: is a test

@christopherfujino
Copy link
Member Author

Landing this without the Mac module_custom_host_app_name_test check as this PR should not affect that test (it is flaking on master), and this PR will help us diagnose a separate flake.

@christopherfujino christopherfujino merged commit d6d3f0e into flutter:master May 17, 2021
@christopherfujino christopherfujino deleted the make-pub-activate-verbose branch May 17, 2021 18:39
@christopherfujino christopherfujino changed the title add --verbose flag to pub global activate [flutter_tools] add --verbose flag to pub global activate Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants