Revert "[flutter_tools] fix top web crasher" #83376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a8ec764.
flutter-dashboard
bot
added
the
tool
grouma
approved these changes
May 25, 2021
zanderso
approved these changes
May 25, 2021
|
From offline discussion, the original crash may be caused by trying to use a stale app connection if the user does a quick refresh. I might be able to re-arrange this method a bit to make this more resilient, for example adding a check after completing the debug connection that we have not received a newer event. |
|
This pull request is not suitable for automatic merging in its current state.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #83272
This broke manually refreshing the page