Reland "Dispose render objects when owning element is unmounted. (#82883)" (#83790) #83920
Conversation
…tter#82883)" (flutter#83790) This reverts commit 63c49c3.
flutter-dashboard
bot
added
d: examples
|
Longer term, the plan is to patch up flare_flutter after 2d-inc/Flare-Flutter#307 lands so that it will work with these new method/lints, and undo some changes to the internal fork that have accumulated over time/migrate internal customers to Rive. |
|
Kicked off a FROB run for this that should run more tests than Google testing does/did. |
|
test/OCL:377331261:BASE:377331237:1622744968484:d1dceb5f is showing a large number of failures due to an unrelated change...Will try to patch the build file after lunch so we can at least test these changes. |
This isn't compatible with some internal customers currently. We will patch them and add this back.
| // child.debugDisposed!, | ||
| // '${child.runtimeType} (child of $runtimeType) must be disposed before calling super.dispose().', | ||
| // ); | ||
| // }); |
There was a problem hiding this comment.
@goderbauer just want to make sure this LGTY with this change - it will be uncommented once we can mitigate internal violations.
|
After cl/377398477 this passes internally. |
This reverts commit 63c49c3.
No changes from last time, but internal CL will avoid breakages. I will try to do a full frob run to verify.
See cl/377329167