Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only trigger AppBar scrolledUnder state for vertical scrolling and not horizontal #84268

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Only trigger AppBar scrolledUnder state for vertical scrolling and not horizontal #84268

merged 2 commits into from
Jun 9, 2021

Conversation

rami-a
Copy link
Member

@rami-a rami-a commented Jun 9, 2021

This change updates the AppBar scrolledUnder state so that it only takes affect on vertical scrolls and not horizontal scrolls. This fixes a bug that was causing the app bar's color to change when a horizontal scrollable moves, when that doesn't make sense conceptually.

Closes #84267

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 9, 2021
@google-cla google-cla bot added the cla: yes label Jun 9, 2021
@rami-a rami-a requested a review from HansMuller June 9, 2021 15:42
johnsonmh
johnsonmh approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@johnsonmh johnsonmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

HansMuller
HansMuller approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit e12c751 into flutter:master Jun 9, 2021
@rami-a rami-a deleted the appbar-horizontal-scrolled-under branch June 9, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansMuller HansMuller HansMuller approved these changes

@johnsonmh johnsonmh johnsonmh approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AppBar scrolledUnder state triggers on horizontal scrolls
4 participants
@rami-a @HansMuller @johnsonmh @fluttergithubbot