Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_tools] add un-discoverable preview device #85253

Merged
merged 4 commits into from Jun 25, 2021

Conversation

jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Jun 24, 2021

Add some basic tool to support a "flutter preview" device is not discoverable and doesn't have artifacts yet.

Work towards #85329

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 24, 2021
@google-cla google-cla bot added the cla: yes label Jun 24, 2021
packages/flutter_tools/lib/src/preview_device.dart Outdated Show resolved Hide resolved
return BundleBuilder();
}

class PreviewDevice extends Device {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a doc comment giving a general overview of what this is for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for prototyping

packages/flutter_tools/lib/src/preview_device.dart Outdated Show resolved Hide resolved
Co-authored-by: Jenn Magder <magder@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants