Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address dev/devicelab todos #85348

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Address dev/devicelab todos #85348

merged 1 commit into from
Jun 28, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jun 25, 2021

Remove two todos, add a tracking issue for a third.
@jmagman part of #85342

@jmagman jmagman added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Jun 25, 2021
@jmagman jmagman self-assigned this Jun 25, 2021
@google-cla google-cla bot added the cla: yes label Jun 25, 2021
@jmagman jmagman requested a review from chunhtai June 26, 2021 00:09
@jmagman jmagman changed the title Address jmagman todos Address dev/devicelab todos Jun 26, 2021
chunhtai
chunhtai approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@fluttergithubbot fluttergithubbot merged commit 610ee89 into flutter:master Jun 28, 2021
@jmagman jmagman deleted the jmagman-todos branch June 28, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees

@jmagman jmagman

Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmagman @chunhtai @fluttergithubbot