Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused build_mode_test #86808

Merged
merged 1 commit into from Jul 21, 2021
Merged

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jul 21, 2021

--dynamic flag was introduced in #20543 and removed in #34736. Test was introduced in #27502.

Part of auditing devicelab tasks: #86802

@jmagman jmagman added a: tests "flutter test", flutter_test, or one of our tests team Infra upgrades, team productivity, code health, technical debt. See also team: labels. c: tech-debt Technical debt, code quality, testing, etc. labels Jul 21, 2021
@jmagman jmagman self-assigned this Jul 21, 2021
@google-cla google-cla bot added the cla: yes label Jul 21, 2021

void main() {
group('Integration Test', () {
testWidgets('smoke test', (WidgetTester tester) async {
app.main();
await tester.pumpAndSettle();

expect(find.text('Hello, world!'), findsOneWidget);
expect(find.byType(SizedBox), findsOneWidget);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I picked another entry point for this smoke test so build_mode could be deleted.

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit f50e231 into flutter:master Jul 21, 2021
@jmagman jmagman deleted the build-mode branch July 21, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: tests "flutter test", flutter_test, or one of our tests c: tech-debt Technical debt, code quality, testing, etc. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants